Feat: Refactor multi version NSO environment - #5
Merged
Conversation
Epaphras1
reviewed
Sep 4, 2026
Contributor
|
Minor question: I noticed create_pyproject() on line 83 still hardcodes pyndev-nso as the dependency group name. Should this also use the new pyndev-nso-{version} naming convention, or is the unversioned name intentional here? |
Epaphras1
reviewed
Sep 4, 2026
Epaphras1
left a comment
Epaphras1
left a comment
Contributor
There was a problem hiding this comment.
I noticed create_pyproject() on line 83 still hardcodes pyndev-nso as the dependency group name. Should this also use the new pyndev-nso-{version} naming convention, or is the unversioned name intentional here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleaned up the NSO multi version handling and documentation udpates